Remove unnecessary haystack length check in stripos()

nikic · nikic · commit 6e3135070c13 · 2019-08-25T16:31:15.000+02:00
This falls out naturally from the following condition, because
either the needle length will be zero as well, or the needle
will be longer than the (empty) haystack.
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -1940,10 +1940,6 @@ PHP_FUNCTION(stripos)
 		RETURN_FALSE;
 	}
 
-	if (ZSTR_LEN(haystack) == 0) {
-		RETURN_FALSE;
-	}
-
 	if (ZSTR_LEN(needle) == 0 || ZSTR_LEN(needle) > ZSTR_LEN(haystack)) {
 		RETURN_FALSE;
 	}

Original file line number	Diff line number	Diff line change
`@@ -1940,10 +1940,6 @@ PHP_FUNCTION(stripos)`
`1940`	`1940`	`RETURN_FALSE;`
`1941`	`1941`	`}`
`1942`	`1942`
`1943`		`- if (ZSTR_LEN(haystack) == 0) {`
`1944`		`- RETURN_FALSE;`
`1945`		`- }`
`1946`		`-`
`1947`	`1943`	`if (ZSTR_LEN(needle) == 0 \|\| ZSTR_LEN(needle) > ZSTR_LEN(haystack)) {`
`1948`	`1944`	`RETURN_FALSE;`
`1949`	`1945`	`}`