Remove unnecessary NULL check

nikic · nikic · commit 4346d1b0e66e · 2019-08-25T16:30:16.000+02:00
needle_dup cannot be NULL here.
diff --git a/ext/standard/string.c b/ext/standard/string.c
@@ -1960,9 +1960,7 @@ PHP_FUNCTION(stripos)
 	}
 
 	zend_string_release_ex(haystack_dup, 0);
-	if (needle_dup) {
-		zend_string_release_ex(needle_dup, 0);
-	}
+	zend_string_release_ex(needle_dup, 0);
 }
 /* }}} */
 

Original file line number	Diff line number	Diff line change
`@@ -1960,9 +1960,7 @@ PHP_FUNCTION(stripos)`
`1960`	`1960`	`}`
`1961`	`1961`
`1962`	`1962`	`zend_string_release_ex(haystack_dup, 0);`
`1963`		`- if (needle_dup) {`
`1964`		`- zend_string_release_ex(needle_dup, 0);`
`1965`		`- }`
	`1963`	`+ zend_string_release_ex(needle_dup, 0);`
`1966`	`1964`	`}`
`1967`	`1965`	`/* }}} */`
`1968`	`1966`