Skip to content

Commit 5ef4602

Browse files
committed
Merge branch 'PHP-8.2'
* PHP-8.2: Another attempt to fix MSAN nightly on master
2 parents c822c2d + 6343975 commit 5ef4602

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

run-tests.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -578,22 +578,15 @@ function main(): void
578578
$environment['USE_TRACKED_ALLOC'] = 1;
579579
$environment['SKIP_ASAN'] = 1;
580580
$environment['SKIP_PERF_SENSITIVE'] = 1;
581-
$lsan_options = [];
582581
if ($switch === '--msan') {
583582
$environment['SKIP_MSAN'] = 1;
584-
// use_tls=0 is a workaround for MSAN crashing with "Tracer caught signal 11" (SIGSEGV),
585-
// which seems to be an issue with TLS support in newer glibc versions under virtualized
586-
// environments. Follow https://github.com/google/sanitizers/issues/1342 and
587-
// https://github.com/google/sanitizers/issues/1409 to track this issue.
588-
$lsan_options[] = 'use_tls=0';
583+
$environment['MSAN_OPTIONS'] = 'intercept_tls_get_addr=0';
589584
}
585+
590586
$lsanSuppressions = __DIR__ . '/.github/lsan-suppressions.txt';
591587
if (file_exists($lsanSuppressions)) {
592-
$lsan_options[] = 'suppressions=' . $lsanSuppressions;
593-
$lsan_options[] = 'print_suppressions=0';
594-
}
595-
if (!empty($lsan_options)) {
596-
$environment['LSAN_OPTIONS'] = join(':', $lsan_options);
588+
$environment['LSAN_OPTIONS'] = 'suppressions=' . $lsanSuppressions
589+
. ':print_suppressions=0';
597590
}
598591
break;
599592
case '--repeat':

0 commit comments

Comments
 (0)