Skip to content

Commit 6343975

Browse files
committed
Merge branch 'PHP-8.1' into PHP-8.2
* PHP-8.1: Another attempt to fix MSAN nightly on master
2 parents 5239f9f + 471105a commit 6343975

File tree

1 file changed

+4
-11
lines changed

1 file changed

+4
-11
lines changed

run-tests.php

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -579,22 +579,15 @@ function main(): void
579579
$environment['USE_TRACKED_ALLOC'] = 1;
580580
$environment['SKIP_ASAN'] = 1;
581581
$environment['SKIP_PERF_SENSITIVE'] = 1;
582-
$lsan_options = [];
583582
if ($switch === '--msan') {
584583
$environment['SKIP_MSAN'] = 1;
585-
// use_tls=0 is a workaround for MSAN crashing with "Tracer caught signal 11" (SIGSEGV),
586-
// which seems to be an issue with TLS support in newer glibc versions under virtualized
587-
// environments. Follow https://github.com/google/sanitizers/issues/1342 and
588-
// https://github.com/google/sanitizers/issues/1409 to track this issue.
589-
$lsan_options[] = 'use_tls=0';
584+
$environment['MSAN_OPTIONS'] = 'intercept_tls_get_addr=0';
590585
}
586+
591587
$lsanSuppressions = __DIR__ . '/.github/lsan-suppressions.txt';
592588
if (file_exists($lsanSuppressions)) {
593-
$lsan_options[] = 'suppressions=' . $lsanSuppressions;
594-
$lsan_options[] = 'print_suppressions=0';
595-
}
596-
if (!empty($lsan_options)) {
597-
$environment['LSAN_OPTIONS'] = join(':', $lsan_options);
589+
$environment['LSAN_OPTIONS'] = 'suppressions=' . $lsanSuppressions
590+
. ':print_suppressions=0';
598591
}
599592
break;
600593
case '--repeat':

0 commit comments

Comments
 (0)