Skip to content

Commit 10fe317

Browse files
committed
Merge branch 'PHP-5.6'
Conflicts: ext/openssl/openssl.c
2 parents 91859f1 + 8309988 commit 10fe317

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

ext/openssl/openssl.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1545,7 +1545,7 @@ PHP_FUNCTION(openssl_spki_new)
15451545
efree(spkstr);
15461546
}
15471547

1548-
if (s->len <= 0) {
1548+
if (s && s->len <= 0) {
15491549
RETVAL_FALSE;
15501550
}
15511551

ext/openssl/tests/bug68912.phpt

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
--TEST--
2+
Bug #68912 (Segmentation fault at openssl_spki_new)
3+
--SKIPIF--
4+
<?php
5+
if (!extension_loaded("openssl")) die("skip");
6+
if (!@openssl_pkey_new()) die("skip cannot create private key");
7+
?>
8+
--FILE--
9+
<?php
10+
11+
$var1=xml_parser_create_ns();
12+
$var2=2;
13+
$var3=3;
14+
15+
openssl_spki_new($var1, $var2, $var3);
16+
?>
17+
--EXPECTF--
18+
Warning: openssl_spki_new(): supplied resource is not a valid OpenSSL X.509/key resource in %sbug68912.php on line %d
19+
20+
Warning: openssl_spki_new(): Unable to use supplied private key in %sbug68912.php on line %d

0 commit comments

Comments
 (0)