Fixed bug #68912 (Segmentation fault at openssl_spki_new)

Author: laruence

NEWS

@@ -9,7 +9,8 @@
   . Bug #68964 (Allowed memory size exhausted with odbc_exec). (Anatol)
 
 - OpenSSL:
-  . Fix bug #61285, #68329, #68046, #41631: encrypted streams don't observe
+  . Fixed bug #68912 (Segmentation fault at openssl_spki_new). (Laruence)
+  . Fixed bug #61285, #68329, #68046, #41631: encrypted streams don't observe
     socket timeouts (Brad Broerman)
 
 - pgsql:

ext/openssl/openssl.c

@@ -1532,7 +1532,7 @@ PHP_FUNCTION(openssl_spki_new)
 		efree(spkstr);
 	}
 
-	if (strlen(s) <= 0) {
+	if (s && strlen(s) <= 0) {
 		RETVAL_FALSE;
 	}
 

ext/openssl/tests/bug68912.phpt

@@ -0,0 +1,20 @@
+--TEST--
+Bug #68912 (Segmentation fault at openssl_spki_new)
+--SKIPIF--
+<?php 
+if (!extension_loaded("openssl")) die("skip");
+if (!@openssl_pkey_new()) die("skip cannot create private key");
+?>
+--FILE--
+<?php
+
+$var1=xml_parser_create_ns();
+$var2=2; 
+$var3=3; 
+
+openssl_spki_new($var1, $var2, $var3);
+?>
+--EXPECTF--
+Warning: openssl_spki_new(): supplied resource is not a valid OpenSSL X.509/key resource in %sbug68912.php on line %d
+
+Warning: openssl_spki_new(): Unable to use supplied private key in %sbug68912.php on line %d