Update README.md to have pre-requisite info. #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hi @NattyNarwhal, Can we update readme as I proposed here, I just added an extra pre-requisite para, most of our DB2 connect customers ask for this info.
|
@NattyNarwhal can you pls consider this on priority. |
|
Requiring PHP seems pretty obvious to me, so I'm not sure why that's needed to be stated. Having a statement of which PHP versions are supported seems beneficial. |
|
@NattyNarwhal Its standard statement we are using across diff drivers like for python, ruby, go etc... We want to maintain the same. Its obvious for experienced developers, for new developers its better to have. |
|
I'd say we support 7.3 still (it's the minreq in |
|
@NattyNarwhal yes we better specify only supported PHP releases. |
|
@kadler @NattyNarwhal I had changed statement as you suggested. Request to review and merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @NattyNarwhal,
Can we update readme as I proposed here, I just added an extra pre-requisite para, most of our DB2 connect customers ask for this info.
Your suggestions to my changes are welcome.