Skip to content

PHP 8.4: CSV related changes and deprecations #4093

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 19, 2024
Merged

Conversation

Girgias
Copy link
Member

@Girgias Girgias commented Nov 18, 2024

I might have pushed it a bit with the XIncludes and XPath queries.

@Girgias Girgias requested a review from cmb69 November 18, 2024 02:15
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have pushed it a bit with the XIncludes and XPath queries.

Yeah, that looks somewhat fragile (e.g. relying on the parameter numbers). Might be better to use some entities here.

Improve XInclude XPath query
Improve See Also
@Girgias Girgias requested a review from cmb69 November 19, 2024 22:43
Copy link
Member

@cmb69 cmb69 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a fan of xincludes, but this looks quite reasonable. Minor nit below.

Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
@Girgias
Copy link
Member Author

Girgias commented Nov 19, 2024

I prefer XIncludes to Entities as language-snippets is a pain as a translator IMHO.

@Girgias Girgias merged commit 73007ad into php:master Nov 19, 2024
2 checks passed
@Girgias Girgias deleted the csv-changes branch November 19, 2024 23:11
@cmb69
Copy link
Member

cmb69 commented Nov 19, 2024

I prefer XIncludes to Entities as language-snippets is a pain as a translator IMHO.

That's true.

@Girgias Girgias added this to the PHP 8.4 milestone Dec 6, 2024
siwa32 added a commit to siwa32/doc-ja that referenced this pull request Jan 13, 2025
php/doc-en#4093

以下も合わせて取り込む

reference/spl/splfileobject/setcsvcontrol.xml
- [skip-revcheck] Fill xi:fallback to avoid 'variablelist incomplete' in some translations
  - php/doc-en#4128
- Update setcsvcontrol.xml Fix typo
  - php/doc-en#4379

reference/spl/splfileobject/fgetcsv.xml
- Update fgetcsv.xml Remove the duplicate sentence
  - php/doc-en#4111
KentarouTakeda added a commit to php/doc-ja that referenced this pull request Jan 19, 2025
* PHP 8.4: CSV related changes and deprecations の取り込み

php/doc-en#4093

以下も合わせて取り込む

reference/spl/splfileobject/setcsvcontrol.xml
- [skip-revcheck] Fill xi:fallback to avoid 'variablelist incomplete' in some translations
  - php/doc-en#4128
- Update setcsvcontrol.xml Fix typo
  - php/doc-en#4379

reference/spl/splfileobject/fgetcsv.xml
- Update fgetcsv.xml Remove the duplicate sentence
  - php/doc-en#4111

* Fix GH-4175: do not say the parameters are optional の取り込み

php/doc-en#4177

* Document str_getcsv() and fgetcsv() change in 8.3.0 (closes #4197) の取り込み

php/doc-en#4198

* Fix: Add explicit $escape parameter in fputcsv for PHP 8.4 compatibility の取り込み

php/doc-en#4283

* 改行位置を原文と合わせる対応

---------

Co-authored-by: 武田 憲太郎 <takeda@youmind.jp>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants