-
Notifications
You must be signed in to change notification settings - Fork 801
PHP 8.4: CSV related changes and deprecations #4093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might have pushed it a bit with the XIncludes and XPath queries.
Yeah, that looks somewhat fragile (e.g. relying on the parameter numbers). Might be better to use some entities here.
Improve XInclude XPath query Improve See Also
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of xincludes, but this looks quite reasonable. Minor nit below.
Co-authored-by: Christoph M. Becker <cmbecker69@gmx.de>
I prefer XIncludes to Entities as |
That's true. |
php/doc-en#4093 以下も合わせて取り込む reference/spl/splfileobject/setcsvcontrol.xml - [skip-revcheck] Fill xi:fallback to avoid 'variablelist incomplete' in some translations - php/doc-en#4128 - Update setcsvcontrol.xml Fix typo - php/doc-en#4379 reference/spl/splfileobject/fgetcsv.xml - Update fgetcsv.xml Remove the duplicate sentence - php/doc-en#4111
* PHP 8.4: CSV related changes and deprecations の取り込み php/doc-en#4093 以下も合わせて取り込む reference/spl/splfileobject/setcsvcontrol.xml - [skip-revcheck] Fill xi:fallback to avoid 'variablelist incomplete' in some translations - php/doc-en#4128 - Update setcsvcontrol.xml Fix typo - php/doc-en#4379 reference/spl/splfileobject/fgetcsv.xml - Update fgetcsv.xml Remove the duplicate sentence - php/doc-en#4111 * Fix GH-4175: do not say the parameters are optional の取り込み php/doc-en#4177 * Document str_getcsv() and fgetcsv() change in 8.3.0 (closes #4197) の取り込み php/doc-en#4198 * Fix: Add explicit $escape parameter in fputcsv for PHP 8.4 compatibility の取り込み php/doc-en#4283 * 改行位置を原文と合わせる対応 --------- Co-authored-by: 武田 憲太郎 <takeda@youmind.jp>
I might have pushed it a bit with the XIncludes and XPath queries.