Skip to content

Make sure we do not bind to specific twig version before the TwigVisi… #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 3, 2017
Merged

Make sure we do not bind to specific twig version before the TwigVisi… #99

merged 2 commits into from
Jun 3, 2017

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Jun 3, 2017

…torFactory has been executed

To fix the error on SF twig1:

Fatal error: Declaration of Translation\Extractor\Visitor\Twig\Twig2Visitor::enterNode(Twig_Node $node, Twig_Environment $env) must be compatible with Twig_NodeVisitorInterface::enterNode(Twig_NodeInterface $node, Twig_Environment $env) in local/path/vendor/php-translation/extractor/src/Visitor/Twig/Twig2Visitor.php on line 20

@Nyholm Nyholm requested a review from rvanlaak June 3, 2017 08:31
@Nyholm Nyholm merged commit 389443e into master Jun 3, 2017
@Nyholm Nyholm deleted the patch-1 branch June 3, 2017 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvanlaak rvanlaak Awaiting requested review from rvanlaak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Nyholm