-
Notifications
You must be signed in to change notification settings - Fork 93
Add Meta Informations to the common Message object #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c15ce33
to
cf45f51
Compare
$this->domain, | ||
$this->locale, | ||
$this->translation, | ||
$meta |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems better to me to add parameters
, count
and transChoiceNumber
to the Message
value object as fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, I'm not sure: the Message object is a common objet used to represent a translation on the storage, and those parameters, count and transChoiceNumber information are only needed when displaying a translation.
Great. This looks good. I merged the two downstream PRs and tagged new releases. |
Clean up done, as the profiler was storing all the parameters from all the calls to a translation, the dumped version could become heavy; I reduce the array to only have one occurrence of each parameter key. |
556a6a4
to
d9b16a1
Compare
Feel free to drop support for HHVM. Symfony has officially dropped it. |
HHVM dropped, but there is a PHP7 syntax error now 😬 https://travis-ci.org/php-translation/symfony-bundle/jobs/238027526 |
Two things:
|
Launched the builds again and it's green 👍 |
See php-translation/loco-adapter#7 and FriendsOfApi/localise.biz#16.
This PR adds Meta informations from the Data Collector Message to the Common Message object. This allow the Loco-Adapter to use this Meta information in order to add the parameters as notes on newly created assets.
Screenshot