add functionality to allow hiding commands in /help command

[lichtscheu]

add protected $showInHelp var to Command.php

add public function getShowInHelp() to Command.php

add if($command->getShowInHelp()) {} to wrap single command output at HelpCommand.php

with protected $showInHelp = false; insert into the command,it is not listed with /help command.

I find this very useful, cause i have some commands i only use over cronjob and don't want this commands to show up at the help command.

[noplanman]

Instead of checking for true and putting all the code into the if block, it's nicer to test for false and just continue with the next element.
e.g.

if (!$command->showInHelp()) {
    continue;
}

Also, remember to keep your code nice and clean, so make the indentation correct 👍

[noplanman]

For properties, we prefer snake case, i.e. $show_in_help

👍 for default being true

[noplanman]

Instead of getShowInHelp, just use showInHelp. Similar to isEnabled, it makes it much easier to "read" the code.

Compare:

$command->getShowInHelp();

to

$command->showInHelp();

See what I mean? 😃

[lichtscheu]

Thanks for the awesome review =)

[noplanman]

Not sure you tested this one, give it a go and see if this does what you want... 😉
Also, there should be a space after the if like so: if (...)

[noplanman]

The indentation was correct, so please revert this part.

[noplanman]

This needs to be /** for docblock to pick it up correctly.

Also, check the number of spaces and compare it with the others.
e.g.:

/**
 * There is an extra space before the *s on these lines!
 */

[noplanman]

Indent by 4 spaces, always.
What editor do you use? Make sure it has an editorconfig plugin installed.

[noplanman]

@lichtscheu Also, notice that the build failed. When you click the Details button, it brings you to the Travis CI page, showing you what went wrong. It's an awesome help to make sure that everything is working properly.

Also, your changes will need some new tests, but I'll do those an PR to your branch so that you can see how they're done. If you feel like trying yourself, feel free to do so!