Skip to content

PHP 8.1 deprecations fix #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2021
Merged

Conversation

maxgorovenko
Copy link
Contributor

? !
Type improvement
BC Break no

Summary

At php 8.1 got some deprecations:

Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in /srv/app/vendor/longman/telegram-bot/src/Entities/Message.php on line 161

Deprecated: strlen(): Passing null to parameter #1 ($string) of type string is deprecated in /srv/app/vendor/longman/telegram-bot/src/Entities/Message.php on line 264

Fix ensures that passed parameter is a string.

@maxgorovenko
Copy link
Contributor Author

@noplanman, I'm sorry, but what should I do next for this pr merged? I see neighboring pr is about one month without any comments.

@noplanman
Copy link
Member

Hi @maxgorovenko, I'm very busy with work and other projects, which is why I've not been very active here. My apologies.

Hope to put aside some time and invest it here, to update things here and there.

Thanks for your fix 👍

@noplanman noplanman merged commit 5e2e3e5 into php-telegram-bot:develop Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants