Refind execution after handle run and added task-after event #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
bugfix/event-after
branch
from
1405cbd to
5ff1595
Compare
danrot
approved these changes
Jan 11, 2017
| @@ -84,6 +79,7 @@ public function runTasks() | |||
| new TaskExecutionEvent($execution->getTask(), $execution) | |||
| ); | |||
| } catch (\Exception $ex) { | |||
| $execution = $this->taskExecutionRepository->findByUuid($execution->getUuid()); | |||
There was a problem hiding this comment.
think we should add an comment here why findByUuid is called.
wachterjohannes
force-pushed
the
bugfix/event-after
branch
from
5ff1595 to
7de3947
Compare
wachterjohannes
force-pushed
the
bugfix/event-after
branch
from
7de3947 to
f7c3aa7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an exception occurs in handler or he clears the storage manager (like entityManager in doctrine) the taskRunner should be able to save the entity although.
For example (with doctrine):
Without these new steps the entityManager will throw an error because of the unknown execution entity-object.