Updated symfony components #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
upgrade/symfony-4
branch
13 times, most recently
from
456eb02 to
ea78137
Compare
Closed
wachterjohannes
force-pushed
the
upgrade/symfony-4
branch
6 times, most recently
from
0c0a837 to
ad4242a
Compare
| env: | ||
| - STORAGE=doctrine | ||
| - COMPOSER_FLAGS="--prefer-lowest --prefer-dist --no-interaction" | ||
| - php: 7.1 |
There was a problem hiding this comment.
we should test on 7.3
There was a problem hiding this comment.
cannot :) we would have to update phpunit and then i cannot test 5.6 😂
There was a problem hiding this comment.
Other bundles are also tested from 5.5 to 7.3 so this should be no problem when allowing newer phpunit version:
"phpunit/phpunit": "^4.8 || ^5.0",
wachterjohannes
force-pushed
the
upgrade/symfony-4
branch
9 times, most recently
from
b9543a9 to
b787432
Compare
wachterjohannes
force-pushed
the
upgrade/symfony-4
branch
5 times, most recently
from
57cc4dc to
03d1597
Compare
wachterjohannes
force-pushed
the
upgrade/symfony-4
branch
from
03d1597 to
5e39020
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
related PRs https://github.com/php-task/php-task/pull/40/files