Added process-executor which uses a process to execute tasks #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chirimoya
requested changes
Aug 11, 2017
composer.json
Outdated
| @@ -11,7 +11,7 @@ | |||
| ], | |||
| "require": { | |||
| "php": "~5.5 || ~7.0", | |||
| "php-task/php-task": "^1.1", | |||
| "php-task/php-task": "dev-feature/handler-executor", | |||
| "symfony/http-kernel": "^2.6 || ^3.0", | |||
src/Command/ExecuteCommand.php
Outdated
| } catch (\Exception $e) { | ||
| $errOutput->writeln($e->__toString()); | ||
|
|
||
| return 1; |
| ->arrayNode('executor') | ||
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->enumNode('type')->values(['inline', 'process'])->defaultValue('inline')->end() |
| ->addDefaultsIfNotSet() | ||
| ->children() | ||
| ->enumNode('type')->values(['inline', 'process'])->defaultValue('inline')->end() | ||
| ->arrayNode('process') |
src/Executor/ProcessException.php
Outdated
| /** | ||
| * Exception wrapper which transports the serialized exception from console to the runner. | ||
| */ | ||
| class ProcessException extends \Exception |
src/Executor/ProcessExecutor.php
Outdated
| /** | ||
| * Uses a process to start the executions via console-command. | ||
| */ | ||
| class ProcessExecutor implements ExecutorInterface |
src/Executor/ProcessExecutor.php
Outdated
| public function execute(TaskExecutionInterface $execution) | ||
| { | ||
| $process = ProcessBuilder::create( | ||
| [$this->consoleFile, 'task:execute', $execution->getUuid(), '-e ' . $this->environment] |
There was a problem hiding this comment.
error handing if console path not exits
There was a problem hiding this comment.
will be done in the TaskExtension
src/Executor/ProcessExecutor.php
Outdated
| */ | ||
| public function __construct($consoleFile, $environment) | ||
| { | ||
| $this->consoleFile = $consoleFile; |
src/Executor/ProcessExecutor.php
Outdated
| * | ||
| * @return string | ||
| */ | ||
| private function extractResult($output) |
wachterjohannes
force-pushed
the
feature/process-executor
branch
from
3b9deda to
a2a3c00
Compare
|
@chirimoya fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR php-task/php-task#38
In addition to the adaptations required by the php-task PR this one adds the
ProcessExecutorwhich uses thesymfony/processcomponent to run the tasks in isolation.