Fixed query to find pending executions #36
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
bugfix/scheduled-query
branch
from
2ab928a to
11f7631
Compare
wachterjohannes
commented
Feb 27, 2017
| @@ -129,17 +129,13 @@ public function findByTaskUuid($taskUuid) | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
| public function findScheduled(\DateTime $dateTime = null) | |||
There was a problem hiding this comment.
the interface has changed a few time ago. so i have removed it also from this class.
wachterjohannes
force-pushed
the
bugfix/scheduled-query
branch
2 times, most recently
from
6542213 to
abe23e2
Compare
danrot
reviewed
Feb 27, 2017
| $this->taskRepository = self::$kernel->getContainer()->get('task.storage.task'); | ||
| } | ||
|
|
||
| public function testSave(TaskInterface $task = null, \DateTime $scheduleTime = null, $status = TaskStatus::PLANNED) |
There was a problem hiding this comment.
Do you really think it is a good idea to reuse the test method? Having the assertions also executed in the other tests feels like something that might bite us one day.
There was a problem hiding this comment.
but this is a "prerequisite" for the other testcases but i could also extract it to another function.
There was a problem hiding this comment.
I would exclude it in another function... There is no need that these tests are executed multiple times within a single run.
wachterjohannes
force-pushed
the
bugfix/scheduled-query
branch
from
abe23e2 to
148115d
Compare
|
@danrot fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the query for
findPendingand make it independent from timezone (by usingnowand give the decision to the database).