Improved architecture of bundle #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wachterjohannes
force-pushed
the
feature/refactoring
branch
from
03a6ecc to
d057083
Compare
wachterjohannes
force-pushed
the
feature/refactoring
branch
from
2df496b to
6c474c6
Compare
| * | ||
| * @author @wachterjohannes <johannes.wachter@massiveart.com> | ||
| */ | ||
| class TaskCompilerPass implements CompilerPassInterface |
There was a problem hiding this comment.
@alexander-schranz do you think we should reintroduce that? in my opinion we should pack this functionality into builders (massive/build-bundle) which creates the tasks with an interval on runtime.
removed unused constant
wachterjohannes
force-pushed
the
feature/refactoring
branch
from
5c489cc to
e165285
Compare
wachterjohannes
force-pushed
the
feature/refactoring
branch
from
3fb728e to
6e5a010
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main PR: php-task/php-task#15