protected abstract method gets removed

[szepeviktor]

WC_Item_Totals protected abstract function get_values_for_total($field);

then

Class WC_Cart_Totals contains 1 abstract method and must therefore be declared abstract
 or implement the remaining methods (WC_Cart_Totals::get_values_for_total)
 in /home/travis/build/php-stubs/woocommerce-stubs/woocommerce-stubs.php on line 15012

@herndlm Please help.

[szepeviktor]

Maybe we should simply not remove protected abstract methods.

[herndlm]

AFAIK protected methods should only be removed if the class is final, I'll check it out.
but in which context did this error occur? what is executing the stubs?

[herndlm]

interesting, there's even a test that makes sure that protected abstract methods stay: https://github.com/php-stubs/generator/blob/v0.8.3/test/files/classes.out.php#L25

[szepeviktor]

what is executing the stubs?

CI

woocommerce-stubs/.travis.yml

Line 39 in 446c335

php -r 'require "vendor/php-stubs/wordpress-stubs/wordpress-stubs.php"; require "woocommerce-stubs.php"; require "woocommerce-packages-stubs.php";'

[szepeviktor]

If you extend WC classes stubs must be executed as stubs are for changing docblocks, not for defining classes and methods.

[herndlm]

I was also looking in the same direction I think. real stubs only provide docblocks and should normally not be executed, but in the wordpress extension we do execute them to define classes and methods I believe.

See https://phpstan.org/user-guide/stub-files and https://phpstan.org/config-reference#bootstrap

I was just looking into this in the extension a bit, but too many tests start failing if I thinker with it because PHPStan doesn't know e.g. wp_get_theme() anymore.

But this might be a different thing, although still related I suppose. The best thing would be to get rid of the stub execution, the second best thing might be to include everything in the stubs still if we have to execute them :/

[herndlm]

It’s like source code, but PHPStan only reads PHPDocs from it. So the namespace and class/interface/trait/method/function names must match with the original source you’re describing.

basically the "problem" is that we need the original source too and we don't have it, except people properly require e.g. composer require johnpbloch/wordpress and configure phpstan to scan that as well. most likely the wordpress "stubs" should then still keep all symbols for now I suppose and we keep executing our "stubs" via the bootstrap config, except you want to change how the extension works / is configured, but I guess this is too annoying for the users.

[szepeviktor]

The best thing would be

Please star my new project: https://github.com/szepeviktor/WordPress-the-good-parts

[tlewap]

Same problem here after upgrading to newest phpstan version

[szepeviktor]

@herndlm How should I investigate it in WC source code?
This proves you right: https://github.com/php-stubs/generator/pull/18/files

[tlewap]

If someone need ugly solution ten you can use sed:

sed -i -e 's#final class WC_Cart_Totals#abstract class WC_Cart_Totals#' vendor/php-stubs/woocommerce-stubs/woocommerce-stubs.php

[szepeviktor]

use sed:

Okay-okay! What about the next abstract problem in future WC releases? I'm not though enough to work more and more.

[tlewap]

I have no idea, its just temporary solution...
In our case we use PHPStan to accept PRs so without that, PRs fails