Skip to content

Attempt to fix error when submitting empty file input #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 24, 2018
Merged

Attempt to fix error when submitting empty file input #84

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81bd0b1
Attempt to fix error when submitting empty file input
benjaminjonard Jan 17, 2018
f25848a
Fix changes requested
benjaminjonard Jan 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions Bridges/HttpKernel.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,21 @@ protected function mapRequest(ServerRequestInterface $psrRequest)
$tmpname = tempnam(sys_get_temp_dir(), 'upload');
$this->tempFiles[] = $tmpname;

file_put_contents($tmpname, (string)$value->getStream());
$value = new \Symfony\Component\HttpFoundation\File\UploadedFile(
$tmpname,
$value->getClientFilename(),
$value->getClientMediaType(),
$value->getSize(),
$value->getError(),
true
);
if (UPLOAD_ERR_NO_FILE == $value->getError()) {
$value = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should rename value to file fr the entire loop.

} else {
if (UPLOAD_ERR_OK == $value->getError()) {
file_put_contents($tmpname, (string)$value->getStream());
}
$value = new \Symfony\Component\HttpFoundation\File\UploadedFile(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use ...UploadedFile as SymfonyFile

$tmpname,
$value->getClientFilename(),
$value->getClientMediaType(),
$value->getSize(),
$value->getError(),
true
);
}
}
}
};
Expand Down