Skip to content

Updated to Symfony 3 #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2016
Merged

Updated to Symfony 3 #18

merged 1 commit into from
Mar 18, 2016

Conversation

gnugat
Copy link

@gnugat gnugat commented Mar 16, 2016

Added support for Symfony 3.

@hbroer
Copy link

hbroer commented Mar 17, 2016

Not shure, but i think Stack/builder needs Version dev-master

@marcj
Copy link
Member

marcj commented Mar 17, 2016

Not so important, I don't know anyone using stack builder, so we could basically remove it completely. It does also currently not even work because of a missing interface StackableBootstrapInterface, and since no one complained, it should be free to remove :)

@andig
Copy link
Contributor

andig commented Mar 17, 2016

^2.6 should include 2.8? Then +1.

@gnugat
Copy link
Author

gnugat commented Mar 17, 2016

@andig: yes it does, ^2.6|^3.0 is basically the same as >=2.6,<4.0.
@hbroer: yes, but we can specify it in the project's composer.json
@marcj: I have no idea why PHP PM HttpKernel bridge requires stack/builder so it's your call ;)

marcj added a commit that referenced this pull request Mar 18, 2016
@marcj marcj merged commit 8216582 into php-pm:master Mar 18, 2016
@hbroer
Copy link

hbroer commented Mar 18, 2016

@gnugat yes, that is possible. But without that entry in projects composer.json composer install will fail.

@marcj i dont see real dependency on stack/builder. "Bootstraps/Laravel.php" contains a use statement without using it, and "Bridges/HttpKernel.php" only at one comment. Is it true, that it isn't required?

https://github.com/php-pm/php-pm-httpkernel/search?utf8=%E2%9C%93&q=Builder

@gnugat
Copy link
Author

gnugat commented Mar 18, 2016

@hbroer It's been removed since your last comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants