Skip to content

Bootstrap fixes #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 19, 2015
Merged

Bootstrap fixes #11

merged 4 commits into from
Sep 19, 2015

Conversation

matt-allan
Copy link
Contributor

Issues this fixes:

  • launching with args like this causes a 'cannot redeclare class' error:
vendor/bin/ppm start --bridge=httpKernel --bootstrap='PHPPM\\Bootstraps\\Laravel'

(note the duplicate slashes)

  • Laravel bootstrap only works for Laravel 4.
  • Laravel bootstrap will allow the server to start with the app set to null.
  • Laravel bootstrap assumes the working directory is the /bootstrap folder instead of the project root.

Matt Allan added 4 commits September 19, 2015 00:44
remove duplicate slashes from appBootstrap classname
9a5909f 
Prevents cannot redeclare class errors if duplicate slashes are present
in the cli arg.
correct HttpKernelInterface docblock namespace
022c160
update $appenv docblocks
a28a4a5
correct the Laravel bootstrap path
b9a40cb 
- fix the path for compatibility with L5 and Lumen
- assume the working dir is the application root
- throw an exception instead of failing silently
andig added a commit that referenced this pull request Sep 19, 2015
@andig
Merge pull request #11 from matthew-james/bootstrap-fixes
c85e122 
Bootstrap fixes
@andig andig merged commit c85e122 into php-pm:master Sep 19, 2015
@bratao bratao mentioned this pull request Jun 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matt-allan @andig