Skip to content

Travis: various tweaks #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 16, 2020

Conversation

jrfnl
Copy link
Collaborator

@jrfnl jrfnl commented Jun 28, 2020

  • sudo: false hasn't been supported on Travis for a long time.
  • Unless there is a specific reason to use --prefer-source, always use --prefer-dist for the composer install command to allow Travis to optimally use the caching feature.

.travis.yml Outdated
cache:
directories:
- vendor
- $HOME/.composer/cache

install:
- composer install --no-interaction --prefer-source
- composer install --no-interaction --prefer-dist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, can you remove option --prefer-source/dist? --prefer-dist is default in Composer, via doc

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jrfnl jrfnl force-pushed the feature/travis-tweak branch from 512dcd4 to 58c0b1b Compare August 14, 2020 14:10
* `sudo: false` hasn't been supported on Travis for a long time.
* Unless there is a specific reason to use `--prefer-source`, always use `--prefer-dist` (default) for the `composer install` command to allow Travis to optimally use the caching feature.
@grogy grogy merged commit 13039fd into php-parallel-lint:master Aug 16, 2020
@grogy
Copy link
Member

grogy commented Aug 16, 2020

Great, thank you :)

@jrfnl jrfnl deleted the feature/travis-tweak branch August 16, 2020 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants