Skip to content

Fix deprecated plugin interface #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 19, 2018
Merged

Fix deprecated plugin interface #2

merged 5 commits into from
Jul 19, 2018

Conversation

monobook
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes

What's in this PR?

  1. Fixed deprecated interface.
  2. Fixed deprecated issues in tests.
  3. Fixed autoload in composer.json (if add plugin as dependency autoload doesn't work)

@@ -33,8 +33,8 @@ class TrackTest extends VcrTestCase

protected function setUp()
{
$this->request = $this->getMock(RequestInterface::class);
$this->response = $this->getMock(ResponseInterface::class);
$this->request = $this->getMockBuilder(RequestInterface::class)->getMock();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you always use createMock() instead?

@monobook
Copy link
Contributor Author

ping?

@dbu dbu merged commit 4306195 into php-http:master Jul 19, 2018
@dbu
Copy link
Contributor

dbu commented Jul 19, 2018

thank you!

@monobook monobook deleted the fix-deprecated-plugin-interface branch July 19, 2018 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants