-
Notifications
You must be signed in to change notification settings - Fork 5
Replace PHPSpec with PHPUnit #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
| <phpunit xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="https://schema.phpunit.de/9.3/phpunit.xsd" bootstrap="./vendor/autoload.php" colors="true" convertErrorsToExceptions="true" convertNoticesToExceptions="true" convertWarningsToExceptions="true"> | ||
| <coverage> | ||
| <include> | ||
| <directory>./</directory> | ||
| </include> | ||
| <exclude> | ||
| <directory>./Resources</directory> | ||
| <directory>./tests</directory> | ||
| <directory>./vendor</directory> | ||
| </exclude> | ||
| </coverage> | ||
| <php> | ||
| <env name="SHELL_VERBOSITY" value="-1"/> | ||
| </php> | ||
| <testsuites> | ||
| <testsuite name="StopwatchPlugin unit tests"> | ||
| <directory suffix="Test.php">./tests/Unit</directory> | ||
| </testsuite> | ||
| </testsuites> | ||
| </phpunit> |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Http\Client\Common\Plugin\Tests\Unit; | ||
|
|
||
| use GuzzleHttp\Psr7\Request; | ||
| use GuzzleHttp\Psr7\Response; | ||
| use Http\Client\Common\Plugin\StopwatchPlugin; | ||
| use Http\Client\Exception\HttpException; | ||
| use Http\Promise\FulfilledPromise; | ||
| use Http\Promise\RejectedPromise; | ||
| use LogicException; | ||
| use PHPUnit\Framework\TestCase; | ||
| use Psr\Http\Message\RequestInterface; | ||
| use Symfony\Component\Stopwatch\Stopwatch; | ||
|
|
||
| final class StopwatchPluginTest extends TestCase | ||
| { | ||
| /** | ||
| * @var Stopwatch | ||
| */ | ||
| private $stopwatch; | ||
|
|
||
| /** | ||
| * @var StopwatchPlugin | ||
| */ | ||
| private $plugin; | ||
|
|
||
| public function setUp(): void | ||
| { | ||
| $this->stopwatch = new Stopwatch(); | ||
| $this->plugin = new StopwatchPlugin($this->stopwatch); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function it_records_event(): void | ||
| { | ||
| // Arrange | ||
| $request = new Request('GET', 'https://localhost'); | ||
| $response = new Response(); | ||
|
|
||
| $next = function (RequestInterface $request) use ($response) { | ||
| return new FulfilledPromise($response); | ||
| }; | ||
| $first = function (RequestInterface $request) { | ||
| throw new LogicException('Should not be called'); | ||
| }; | ||
|
|
||
| // Act | ||
| $this->plugin->handleRequest($request, $next, $first); | ||
|
|
||
| // Assert | ||
| $this->assertCount(1, $this->stopwatch->getSections()); | ||
| $this->assertFalse($this->stopwatch->getSectionEvents('__root__')['GET https://localhost']->isStarted()); | ||
| } | ||
|
|
||
| /** | ||
| * @test | ||
| */ | ||
| public function it_records_event_on_error(): void | ||
| { | ||
| // Arrange | ||
| $request = new Request('GET', 'https://localhost'); | ||
| $response = new Response(); | ||
|
|
||
| $next = function (RequestInterface $request) use ($response) { | ||
| return new RejectedPromise(new HttpException('', $request, $response)); | ||
| }; | ||
| $first = function (RequestInterface $request) { | ||
| throw new LogicException('Should not be called'); | ||
| }; | ||
|
|
||
| // Act | ||
| $this->plugin->handleRequest($request, $next, $first); | ||
|
|
||
| // Assert | ||
| $this->assertCount(1, $this->stopwatch->getSections()); | ||
| $this->assertFalse($this->stopwatch->getSectionEvents('__root__')['GET https://localhost']->isStarted()); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the phpunit convention is to have methods start with
testand then we would not need the annotation.i don't know how much people use this form or the other form (but all things i work on have the
testXYform). wdyt of renaming this to testRecordEvent, and the other testRecordError ?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both are fine.. in our code base we only use it_should_be.... together with @test
I decided to keep the original names from phpspec... given there are just 2, does it really matter? :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, does not really matter. just noticed and wanted to discuss it. fine for me.