Skip to content

Allow PHP 8 #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 30, 2020
Merged

Allow PHP 8 #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
89c1574
Allow PHP 8
ddeboer Nov 30, 2020
ef6cdb3
Use newer PHPSpec to fix namespace issue
ddeboer Nov 30, 2020
6822cdb
Remove short_array_syntax
ddeboer Nov 30, 2020
1f5ce55
Clean up testing matrix
ddeboer Nov 30, 2020
f1a6e3f
Narrow PHP version constraint
ddeboer Nov 30, 2020
36161e4
Remove custom dependency
ddeboer Nov 30, 2020
1e71908
Run coverage on 7.4
ddeboer Nov 30, 2020
1713cf2
Remove code coverage monitoring
ddeboer Nov 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .styleci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,3 @@ finder:
path:
- "src"
- "tests"

enabled:
- short_array_syntax
9 changes: 4 additions & 5 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,13 @@ matrix:
fast_finish: true
include:
# Test with lowest dependencies
- php: 7.1
- php: 7.3
env: COMPOSER_FLAGS="--prefer-stable --prefer-lowest" SYMFONY_DEPRECATIONS_HELPER="weak"

# Test the latest stable release
- php: 7.1
- php: 7.2
- php: 7.3
env: COVERAGE=true TEST_COMMAND="composer test-ci" DEPENDENCIES="henrikbjorn/phpspec-code-coverage:^1.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may need some discussion, but this dependency is deprecated so I decided to remove code coverage.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine for me

- php: 7.4
- php: 8.0snapshot

# Force some major versions of Symfony
- php: 7.3
Expand All @@ -35,7 +34,7 @@ matrix:
env: SYMFONY_REQUIRE="5"

# Latest commit to master
- php: 7.3
- php: 8.0snapshot
env: STABILITY="dev"

allow_failures:
Expand Down
4 changes: 2 additions & 2 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,12 +11,12 @@
}
],
"require": {
"php": "^7.1",
"php": "^7.3 || ^8.0",
"symfony/stopwatch": "^3.4 || ^4.0 || ^5.0",
"php-http/client-common": "^1.9 || ^2.0"
},
"require-dev": {
"phpspec/phpspec": "^2.5 || ^3.0 || ^4.0"
"phpspec/phpspec": "^7.0"
},
"autoload": {
"psr-4": {
Expand Down