Skip to content

Upgrade to PSR18 + Httplug 2.0 #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Mar 23, 2019
Merged

Upgrade to PSR18 + Httplug 2.0 #41

merged 16 commits into from
Mar 23, 2019

Conversation

joelwurtz
Copy link
Member

  • Add support for PSR18 and httplug 2.0
  • Fixes some cs
  • Remove support for php < 7.1

@joelwurtz joelwurtz mentioned this pull request Jan 21, 2019
Closed
bastnic and others added 2 commits January 21, 2019 15:53
@bastnic @joelwurtz
TLS v1 is not accepted anymore
6636c00 
I got errors like that all the time since the servers I contact updated their lib.

> OpenSSL Error messages:
error:1409442E:SSL routines:SSL3_READ_BYTES:tlsv1 alert protocol version
@joelwurtz
Add changelog for new ssl default
0b3d757
@joelwurtz joelwurtz mentioned this pull request Jan 21, 2019
Closed
@joelwurtz
Copy link
Member Author

Failure is only due to styleci (removed the config file), integration should be removed (but maybe existing pr still have checks ?)

Should be ready to review / merge @php-http/httplug

dbu
dbu reviewed Jan 21, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@dbu
Copy link
Contributor

dbu commented Jan 21, 2019

i just now removed styleci hooks in this github repo

Nyholm
Nyholm requested changes Jan 21, 2019
View reviewed changes
@joelwurtz
Copy link
Member Author

@dbu i thin there is still a problem somewhere in this repo settings, there is no more travis ci integration and merge request expect style ci integration to bo reported (but it should not)

@dbu
Copy link
Contributor

dbu commented Jan 22, 2019

i don't know what is up with travis-ci, i see the webhook and service integration in the settings of this repo. i don't see any styleci here anymore, did this not get removed now?

@Nyholm
Copy link
Member

Nyholm commented Jan 22, 2019

Sorry, I replied to Joel in a direct message. I updated the branch protection so it does no longer require style CI to pass.

@dbu
Copy link
Contributor

dbu commented Jan 22, 2019

ah, i missed that. there is now something with travis-ci as well. its correct to require it, but it seems to not have run although i have set the callback hook in the settings. am i missing something?

dbu
dbu reviewed Jan 24, 2019
View reviewed changes
@joelwurtz
Copy link
Member Author

I'm still confused about settings of the repository, there is no more travis build on 2.x is this normal ?

@joelwurtz joelwurtz closed this Feb 20, 2019
@joelwurtz joelwurtz reopened this Feb 20, 2019
@joelwurtz joelwurtz closed this Feb 20, 2019
@joelwurtz joelwurtz mentioned this pull request Feb 20, 2019
Closed
@joelwurtz joelwurtz reopened this Feb 20, 2019
@joelwurtz joelwurtz merged commit 5df1859 into master Mar 23, 2019
@joelwurtz joelwurtz deleted the 2.x branch March 23, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu left review comments

@Nyholm Nyholm Nyholm requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joelwurtz @dbu @Nyholm @bastnic