Skip to content

Clean up event loop left overs from promise #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

WyriHaximus
Copy link
Collaborator

I somehow missed those while working on #50

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
License MIT

@WyriHaximus WyriHaximus mentioned this pull request Nov 13, 2022
2 tasks
@dbu
Copy link
Contributor

dbu commented Nov 14, 2022

neat, no more passing the event loop around 👍

can you run the cs fixer, or apply the reported changes by hand please?

@dbu
Copy link
Contributor

dbu commented Nov 14, 2022

and once this is merged, should i tag 4.0.0 with it?

@WyriHaximus WyriHaximus force-pushed the 4.x-clean-up-loop-left-overs-from-promise branch from 4773b70 to 421bb9b Compare November 14, 2022 09:42
@WyriHaximus
Copy link
Collaborator Author

can you run the cs fixer, or apply the reported changes by hand please?

Sure let me fix those.

neat, no more passing the event loop around 👍
and once this is merged, should i tag 4.0.0 with it?

There is one more thing to consider. And that is that the event loop isn't needed anymore in this pack even for the HTTP client. The same Loop::get() is used internally there when no event loop is provided. And since async and await also do that it can be removed there as well. (Already prepaeed a branch for that if you want to do that.)

I somehow missed those while working on php-http#50
@WyriHaximus WyriHaximus force-pushed the 4.x-clean-up-loop-left-overs-from-promise branch from 421bb9b to 931ef9a Compare November 14, 2022 09:48
@WyriHaximus
Copy link
Collaborator Author

Opened the client changes in draft over at #58 It would require this one to be merged first.

@dbu dbu merged commit 554b31d into php-http:4.x Nov 14, 2022
@WyriHaximus WyriHaximus deleted the 4.x-clean-up-loop-left-overs-from-promise branch November 14, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants