Detect supported PHP versions in range during CI instead of hardcoding them #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 9, 2022
Closed
dbu
reviewed
May 9, 2022
…g them The proposed changes use a GitHub Actions I created to detect supported PHP version in range of composer.json.
WyriHaximus
force-pushed
the
detect-support-php-versions-in-range-during-ci-instead-of-hardcoding-them
branch
from
0ca34fe to
c804b87
Compare
|
the static analysis issue is not related to this PR. i will merge this, thanks! |
WyriHaximus
deleted the
detect-support-php-versions-in-range-during-ci-instead-of-hardcoding-them
branch
|
Awesome, I'll rebase #50 next |
WyriHaximus
added a commit
to WyriHaximus-labs/react-adapter
that referenced
this pull request
Jun 28, 2022
Move and also bump phpunit/phpunit to require dev as it was wrongfully place in require in php-http#52.
WyriHaximus
added a commit
to WyriHaximus-labs/react-adapter
that referenced
this pull request
Jul 11, 2022
Move and also bump phpunit/phpunit to require dev as it was wrongfully place in require in php-http#52.
WyriHaximus
added a commit
to WyriHaximus-labs/react-adapter
that referenced
this pull request
Jul 14, 2022
Move and also bump phpunit/phpunit to require dev as it was wrongfully place in require in php-http#52.
WyriHaximus
added a commit
to WyriHaximus-labs/react-adapter
that referenced
this pull request
Jul 28, 2022
Move and also bump phpunit/phpunit to require dev as it was wrongfully place in require in php-http#52.
WyriHaximus
added a commit
to WyriHaximus-labs/react-adapter
that referenced
this pull request
Jul 30, 2022
Move and also bump phpunit/phpunit to require dev as it was wrongfully place in require in php-http#52.
WyriHaximus
added a commit
to WyriHaximus-labs/react-adapter
that referenced
this pull request
Jul 30, 2022
Move and also bump phpunit/phpunit to require dev as it was wrongfully place in require in php-http#52.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
The proposed changes use a GitHub Actions I created to detect supported PHP version in range of composer.json.
Why?
To lower maintenance when new PHP releases come out in the future.
Checklist