Skip to content

Add full support for PSR-18 #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

shulard
Copy link
Collaborator

@shulard shulard commented Dec 17, 2020

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Related tickets fixes #34
Documentation
License MIT

What's in this PR?

Now, the HTTP request will not trigger a non PSR compatible exception.

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

Now, the HTTP request will not trigger a non PSR compatible exception.
See php-http#34
@shulard
Copy link
Collaborator Author

shulard commented Dec 17, 2020

It's a tiny change but maybe we can merge this one before the v3.0.0 release. What do you think @dbu ?

Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, lets get this in. it is no BC break but valuable to comply with the standard that we helped building ;-)

@shulard shulard merged commit 230702a into php-http:master Dec 17, 2020
@shulard shulard deleted the chore/psr18 branch December 17, 2020 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support PSR-18
2 participants