Rewrite promise #23
Merged
Rewrite promise #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
approved these changes
Aug 31, 2017
|
For me the BC break is only on the Promise which is IMO something internal (i added the flag) |
|
You also made that class final. |
|
Hm right, we can tag 2.0, not really harmless to have directly that, upgrade is easy, but at least we are clear in the contract |
|
If you are confident with these changes, then Im happy to tag 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Rewrite the Promise class
Why?
Old behavior was never chaining result (see first commit with the test), thus updating the response through decorated or plugin system was never working, neither transforming response to exception (or vice versa)