Updated to stable versions of Httplug #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "react/http-client": "^0.4.8", | ||
| "react/dns": "^0.4.1", | ||
| "react/stream": "^0.4.3" | ||
| }, | ||
| "require-dev": { | ||
| "guzzlehttp/psr7": "^1.0", | ||
| "php-http/adapter-integration-tests": "dev-master" | ||
| "php-http/client-common": "^1.0", |
There was a problem hiding this comment.
Why is this a dev dependency?
|
Thank you for reviewing this so quickly. I have addressed your comments and Im waiting for Travis to run the tests. |
|
There. The tests passes |
| @@ -12,14 +12,15 @@ | |||
| ], | |||
| "require": { | |||
| "php": ">=5.4", | |||
| "php-http/client-common": "^0.1.1", | |||
There was a problem hiding this comment.
I meant, why is this removed? Is this not necessary?
|
Hm, it seems the react client might be discoverable after all. Let's merge this, I will add a PR for discovery stuff. |
sagikazarmark
added a commit
that referenced
this pull request
Mar 2, 2016
Updated to stable versions of Httplug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a cleanup and using stable versions of Httplug.
I would prefer to make a first tag after this PR so we can use it for tests in HttplugBundle.