Build with PHP 8.0 and 8.1 #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi, thanks for this pull request. i don't really see the value in blocking old versions if we do not have changes that require the new versions. i would suggest to for now only add the build with 8.0 and 8.1 to the ci. as soon as we have changes on the code that have a benefit from dropping php 7 support, i am fine to drop it. |
nbayramberdiyev
changed the title
|
Reverted version bumps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR drops support for PHP 7.x and bumps dependencies accordingly.This will probably require a major version release. The repositories that support PHP 7.x can continue to use the current version (^1.2).Why?
PHP versions 7.x have reached their end of life. PHP 8.0 and 8.1 are only versions that are currently supported. PHP 8.2 will be released in a week.
Checklist
To Do