Do not use sendAsyncRequest for synchronous requests

[mekras]

PluginClient uses sendAsyncRequest method for synchronous requests. This may lead to overhead and slowdown, because async logic is more complex.

[dbu]

i think the reason was to avoid duplicated code. but maybe we can find a way to avoid too much duplication? @joelwurtz would it be enough to create a different $lastCallable depending on what was requested?

[joelwurtz]

Maybe the lastest callable can be changed but we have to keep promise
structure
Le 23 nov. 2015 4:19 PM, "David Buchmann" notifications@github.com a
écrit :

i think the reason was to avoid duplicated code. but maybe we can find a
way to avoid too much duplication? @joelwurtz
https://github.com/joelwurtz would it be enough to create a different
$lastCallable depending on what was requested?

—
Reply to this email directly or view it on GitHub
#14 (comment).

[sagikazarmark]

I have to agree. Also, if not sticking to promises, we would still have to build a callable chain which would probably end up with the same complexity.

[dbu]

agree, we would not want to end up with duplicated code for every plugin. so the EmulateAsyncClient would be what @mekras asks for, right? or where you worried by something else than the actual client call?

[sagikazarmark]

Actually, now that all of the logic is moved from the EmulateAsync client to client-tools package, we could move back the EmulateAsyncClient class here and remove the utils dependency.