Adding tests on appveyor #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ping @GreenSuslik have you tested your patch? Does it work for you? |
|
@Nyholm Yep it's work, basename return bad name |
But so does pathname... I cannot write tests that confirms the bug and that pathname fixes... However, I rewrote your PR into this PR. Does this PR also work for you? |
Nyholm
commented
Dec 22, 2016
| * | ||
| * @return string | ||
| */ | ||
| private function basename($path) |
There was a problem hiding this comment.
Ping @sagikazarmark and @dbu
Is this function overkill or is it the way to go if we want to be independent of the locale?
There was a problem hiding this comment.
quite horrible that php does not provide something that "just works" but it does look correct to me, so i guess lets go with this.
|
Yes, PR #20 work for me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.