Skip to content

Bad ? annotation on MultipartStreamBuilder #41

Closed
@mdelanoue

Description

@mdelanoue

Hi,
I'm not sure but on the diff 67c0c52#diff-8005f3317cfca4af8c4c3c618b7799ec

you change

- use Http\Message\StreamFactory;
+ use Http\Message\StreamFactory as HttplugStreamFactory;

but in the constructor the annotation StreamFactory doesn't change

   /**
     * @param StreamFactory|StreamFactoryInterface|null $streamFactory
     */
    public function __construct($streamFactory = null)
    {
        if ($streamFactory instanceof StreamFactoryInterface || $streamFactory instanceof HttplugStreamFactory) {
            $this->streamFactory = $streamFactory;

            return;
        }
        ....
    }

Is it a forgetfulness ?

Thanks for your help

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions