Skip to content

Remove dependency on php-http/message-factory #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 14, 2023
Merged

Remove dependency on php-http/message-factory #62

merged 1 commit into from
May 14, 2023

Conversation

JoepdeJong
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Related tickets
Documentation
License MIT

php-http/message-factory is not required anymore. this package is also deprecated and replaced by psr/http-factory.

dbu
dbu approved these changes May 14, 2023
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, indeed we seem to not use the obsolete factory in the mock client at all.

@dbu dbu merged commit 12107a1 into php-http:1.x May 14, 2023
@MoroseCorpse
Copy link

It would be great if you could release a new version with this change.

@dbu
Copy link
Contributor

dbu commented May 17, 2023

right: https://github.com/php-http/mock-client/releases/tag/1.5.2

@benjaminmal benjaminmal mentioned this pull request May 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JoepdeJong @MoroseCorpse @dbu