Implement default response and exception #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soullivaneuh
force-pushed
the
default-response-exception
branch
from
3db9075 to
5ff102f
Compare
dbu
requested changes
Nov 8, 2017
src/Client.php
Outdated
| @@ -82,6 +100,16 @@ public function addException(\Exception $exception) | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the default exception to throw if none added. | |||
There was a problem hiding this comment.
... to throw when the list of added exceptions and responses is exhausted.
and maybe add a second bit saying "If both a default exception and a default response are set, the exception will be thrown."
src/Client.php
Outdated
| @@ -92,6 +120,16 @@ public function addResponse(ResponseInterface $response) | |||
| } | |||
|
|
|||
| /** | |||
| * Sets the default response to be returned if none added. | |||
There was a problem hiding this comment.
same as for setDefaultException
soullivaneuh
force-pushed
the
default-response-exception
branch
from
5ff102f to
9490607
Compare
|
@dbu updated. |
dbu
approved these changes
Nov 8, 2017
|
Thanks a lot @soullivaneuh |
|
You are welcome! 👍 Any chance to have a new minor release for that? :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
It allows to set a default response or exception if we don't care about what to returns but can't return an empty one.
Why?
This implements an idea from @dbu (#3 (comment)).
But this is a partial resolution of #3 only.
Example Usage
See the documentation PR.
Checklist