Force proper arg separator to avoid composing broken URLs #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Make sure
http_build_query()
uses&
as argument separator when assemble query params in URL.Why?
By default,
http_build_query()
uses arg_separator.output from php.ini. But this may be set to anything (most often&
because of some legacy apps), which will then silently break URLs assembled by the plugin.For example Guzzle does this as well by default when assembling query strings.
Without the fix this also obviously breaks unit tests when run on our system:
Checklist