Bug/curl fromater fails #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I create PR, but I have several variants of task solve, but I don’t know which is needed. |
Nyholm
requested changes
Mar 7, 2018
| $command .= sprintf(' --data %s', escapeshellarg($data)); | ||
|
|
||
| $escapedData = @escapeshellarg($data); | ||
| if (isset($php_errormsg)) { |
There was a problem hiding this comment.
Wouldn't this always be false? Nothing defines $php_errormsg, right?
|
|
||
| $escapedData = @escapeshellarg($data); | ||
| if (isset($php_errormsg)) { | ||
| throw new \InvalidArgumentException($php_errormsg); |
There was a problem hiding this comment.
We do not want any exceptions or errors here. We want to silently fail. If we want to be extra nice to the user we may include a error message in the command.
// if fail:
$escapedData = 'We cound not escape the data properly';escapeshallarg failed
Nyholm
reviewed
Apr 3, 2018
| @@ -45,7 +45,11 @@ public function formatRequest(RequestInterface $request) | |||
| } else { | |||
| $data = '[non-seekable stream omitted]'; | |||
| } | |||
| $command .= sprintf(' --data %s', escapeshellarg($data)); | |||
|
|
|||
| $escapedData = @escapeshellarg($data) or | |||
There was a problem hiding this comment.
Lets make this more pretty by doing multiple lines.
$escapedData = @escapeshellarg($data);
if (empty($escapedData)) {
$escapedData = 'We couldn't not escape the data properly';
}
|
Any updates on this PR? |
|
@Nyholm I'll do it asap |
|
Thanks, you good for me, poke @Nyholm |
joelwurtz
approved these changes
Jul 9, 2018
Nyholm
approved these changes
Jul 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Added suppress to CurlFormatter for big file error.