Improve formatting of requests with binary streams #92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
This PR fixes the handling of null bytes in
CurlCommandFormatter
. Up to now, an exception is thrown inescapeshellarg
. In addition, non-seekable streams get formatted in the same manner.Example Usage
Requests containing null bytes are formatted as follows:
Checklist
To Do
escapeshellarg()
doesn't help as it would just pass all control characters (except \0). An example of such routines can be found in Chromium.