Skip to content

Added Slim to puli.json #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2016
Merged

Added Slim to puli.json #55

merged 1 commit into from
Oct 15, 2016

Conversation

Nyholm
Copy link
Member

@Nyholm Nyholm commented Oct 15, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets
Documentation
License MIT

Slim factories need to be in puli.json.

For future reference. This is how I did. (Ping @tuupola)

$ php puli.phar bind -f Http\\Message\\MessageFactory\\SlimMessageFactory Http\\Message\\MessageFactory
$ php puli.phar bind -f Http\\Message\\MessageFactory\\SlimMessageFactory Http\\Message\\ResponseFactory
$ php puli.phar bind -f Http\\Message\\MessageFactory\\SlimMessageFactory Http\\Message\\RequestFactory
$ php puli.phar bind -f Http\\Message\\StreamFactory\\SlimStreamFactory Http\\Message\\StreamFactory
$ php puli.phar bind -f Http\\Message\\UriFactory\\SlimUriFactory Http\\Message\\UriFactory   

@sagikazarmark sagikazarmark merged commit d42a563 into master Oct 15, 2016
@sagikazarmark sagikazarmark deleted the puli-slim branch October 15, 2016 13:41
@tuupola
Copy link
Contributor

tuupola commented Oct 15, 2016

Am I correct that for discovery to work without Puli Slim factories should also be added here?

https://github.com/php-http/discovery/blob/master/src/Strategy/CommonClassesStrategy.php

@sagikazarmark
Copy link
Member

Yes, you are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants