Added a formatter that shows the full header and body of the HTTP message #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -6,6 +6,9 @@ | |||
|
|
|||
| - #41: Response builder broke header value | |||
|
|
|||
| ### Added | |||
There was a problem hiding this comment.
Please keep alphabetic order in the changelog.
|
LGTM, added a few comments. |
|
thanks tobias, you had a busy weekend! we might expand this to have a limit on each header as well. headers can technically be very long as well, at least up to 1000 characters. having a limit of 100 or 200 would rarely be hit, but if it is hit it would be relevant to not drown a log in gibberish... but this can be added later if somebody wants to make the effort. |
|
Yeah, if we had an MVP, that would be @Nyholm now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
A new formatter that show the full HTTP message. The formatter takes a constructor argument to adjust the length of the body. If the length is set to
0we would only see the headers. (naturally).Why?
I will need this formatter in a (WIP) PR on the HTTPlug bundle. I want to show the changes each Plugin does on the request and responses.
Im not sure this formatter belongs here, but I think there is a fairly common use case to be able to see full requests. If it is rejected here I will push it to the HTTPlug repo.
Checklist