Fix #41: Response builder broke header value #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As specified at [RFC7230](https://tools.ietf.org/html/rfc7230#section-3.2.4), headers charset should be limited to US-ASCII.
| $name = trim(urldecode($parts[0])); | ||
| $value = trim(urldecode($parts[1])); | ||
| $name = trim($parts[0]); | ||
| $value = trim($parts[1]); |
There was a problem hiding this comment.
the urldecode was in there from the beginning. is something else doing that decoding in reality? is your test failing if you keep the urldecode here?
There was a problem hiding this comment.
the urldecode was in there from the beginning. is something else doing that decoding in reality?
See comment for 60fe987
is your test failing if you keep the urldecode here?
Yes.
There was a problem hiding this comment.
It seems to me the urldecode is not necessary, only ascii characters are allowed.
|
Thank you for your work @mekras. Looks good to me. I am happy to merge it after a squash. |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist