Single header line parsing extracted to a separate method in ResponseBuilder #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Wonder if we should add more tests for the addHeader method separately. |
|
@sagikazarmark, may be. But a) new method is fully covered with existed tests; b) |
|
Ok. Lemme check if I can do something on this front during the weekend. |
| $this->response = $this->response | ||
| ->withStatus((int) $parts[1], $reasonPhrase) | ||
| ->withProtocolVersion(substr($parts[0], 5)); | ||
|
|
There was a problem hiding this comment.
I dont think this should be handled via the addHeader method as it's not a header but more the status string, also now a request like this :
Header: headervalue
GET / HTTP/1.1
would be correctly parsed but is invalid and should throw an error
…etHeadersFromArray().
|
👍 LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows more flexible use of the class.