Skip to content

add Header authentication method #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2019
Merged

add Header authentication method #118

merged 1 commit into from
Sep 16, 2019

Conversation

fbourigault
Copy link
Contributor

@fbourigault fbourigault commented Sep 12, 2019 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Related tickets none
Documentation php-http/documentation#270
License MIT

What's in this PR?

This add a Header authentication method for arbitrary header based authentication (like X-AUTH-TOKEN).

Example Usage

new AuthenticationPlugin(new Header('X-AUTH-TOKEN', 'REAL'));

Checklist

  • Updated CHANGELOG.md to describe BC breaks / deprecations | new feature | bugfix
  • Documentation pull request created (if not simply a bugfix)

dbu
dbu approved these changes Sep 16, 2019
View reviewed changes
Copy link
Contributor

@dbu dbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me. can you please do the pull request to document this?

@fbourigault fbourigault mentioned this pull request Sep 16, 2019
Merged
Nyholm
Nyholm approved these changes Sep 16, 2019
View reviewed changes
Copy link
Member

@Nyholm Nyholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@Nyholm Nyholm merged commit 144d13b into php-http:master Sep 16, 2019
@fbourigault fbourigault deleted the header-authentication branch September 16, 2019 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbu dbu dbu approved these changes

@Nyholm Nyholm Nyholm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbourigault @dbu @Nyholm