Fix fatal error for long bodies #116
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbu
approved these changes
Aug 3, 2019
There was a problem hiding this comment.
thanks for looking into this!
i wonder if it even makes sense to output more than 8K of body - it will be hard to copy-paste and might explode things like the symfony debug panel. i feel that people would want to log larger bodies to some file if they need to debug something. maybe lets just limit to 8192 and say that this should work on all operating systems. wdyt?
Totally agree, it's neither user friendly nor memory friendly |
dbu
approved these changes
Aug 3, 2019
dbu
reviewed
Aug 3, 2019
|
thanks! |
|
released 1.8.0 with this and some other fixes. |
ArthurJam
pushed a commit
to ArthurJam/message
that referenced
this pull request
Oct 19, 2021
* Fix fatal error for long bodies * Set body size limit to 8192 * Phrasing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Prevent
CurlCommandFormatterto throw a Fatal exception when body size exceedescapeshellargargument allowed length. Didn't find a great way to get the limit tho... Windows limit come from PHP source code, the UNIX fromIf you have a better solution to find
escapeshellarglimit, I'm all earsChecklist