Test on php 7.3 #107
Merged
Test on php 7.3 #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
is there a change in php 7.2 that messes up our chunk stream? or only the test for the chunk stream? |
|
From what i have seen it seems that And i don't know a way to mimick this behavior, should we just skip this test ? |
|
Ok, after some search it's coming from fread which now better respect length pass to it #110 should fix those tests |
|
can you please rebase on master now that the chunk issue should be fixed? |
|
I think tests are played on the merged version and since there are green we can safely merge this ? |
dbu
approved these changes
Feb 19, 2019
|
thanks. indeed, restarting the tests was enough. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.