This repository was archived by the owner on May 13, 2023. It is now read-only.
Deprecate our factory interfaces #39
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
While deprecation is OK, I think we should provide a forward compatibility layer between PSR-17 and this package, see #38
| ## Deprecation notice | ||
|
|
||
| This package and these PSR-7 factory interfaces are deprecated. We have succeeded with our goal of moving these | ||
| interfaces to PHP-FIG. The new [PSR-17](https://packagist.org/packages/psr/http-factory) package is backwards compatible |
There was a problem hiding this comment.
I don't think it's true. The API might not break, but you won't get the same PSR-7 object.
There was a problem hiding this comment.
well, if its the same http message, it should be BC. if its not the same PSR-7 implementation, that should not matter, as code should not rely on a factory returning a specific implementation. or do you mean something else?
|
i forgot about this. i now merged #42 and will add a note to the README. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is time. We succeeded!