Add Promise return type doc in Async client #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -19,7 +19,7 @@ | |||
| * | |||
| * @param RequestInterface $request | |||
| * | |||
| * @return Promise | |||
| * @return Promise MUST return with a PSR-7 Response. | |||
There was a problem hiding this comment.
Not a fan :p
More like :
The promise resolve a ResponseInterface or fail with a Http\Client\Exception
There was a problem hiding this comment.
Sounds good to me.
sagikazarmark
force-pushed
the
promise_result
branch
2 times, most recently
from
4929c24 to
3b9ad38
Compare
|
Looks better? |
|
Would remove "MUST" as the message is more for the user, and people implementing the library must conform with the view of the user |
|
A part from that 👍 |
sagikazarmark
force-pushed
the
promise_result
branch
from
3b9ad38 to
7b0896a
Compare
joelwurtz
added a commit
that referenced
this pull request
Jan 25, 2016
Add Promise return type doc in Async client
Nyholm
pushed a commit
to Nyholm/httplug
that referenced
this pull request
Dec 26, 2019
Allow 0 for captured_body_length
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.