Add promise resolution type #80
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -27,6 +31,9 @@ request with HTTPlug:: | |||
|
|
|||
| See :ref:`message-factory` on how to use message factories. | |||
|
|
|||
| Although the promise itself is not restricted to resolve a specific result type, | |||
| in HTTP context it resolves a PSR-7 Response or fails with an ``Http\Client\Exception``. | |||
There was a problem hiding this comment.
i would double backtick Response (probably with FQN to be consistent with the exception class)
|
👍 - feel free to merge once you checked the one feedback i have. |
sagikazarmark
force-pushed
the
promise_result
branch
from
70e476a to
b17faa4
Compare
sagikazarmark
added a commit
that referenced
this pull request
Jan 26, 2016
Add promise resolution type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.